alamb commented on issue #13943: URL: https://github.com/apache/datafusion/issues/13943#issuecomment-2566517237
Thank you for this @njsmith -- I agree this current situation is confusing and seems like maybe is left over from some long ago time ago I poked around a bit this morning and I agree with your options to simplify. It seems like `DefaultQueryPlanner` just passes directly through DefaultPhysicalPlanner https://github.com/apache/datafusion/blob/e718c1a5c5770c071c9c2e14a7681a7f1a2f3f23/datafusion/core/src/execution/session_state.rs#L1935-L1934 Thus, perhaps we could deprecate / remove `QueryPlanner` and the various `SessionState` methods around that, and allow users to register their own `PhysicalPlanner` directly 🤔 They could still provide their own physical planner, but without having to add the extra level of indirection -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
