vbarua commented on code in PR #13931: URL: https://github.com/apache/datafusion/pull/13931#discussion_r1899718265
########## datafusion/substrait/tests/cases/roundtrip_logical_plan.rs: ########## @@ -571,6 +571,21 @@ async fn roundtrip_self_implicit_cross_join() -> Result<()> { roundtrip("SELECT left.a left_a, left.b, right.a right_a, right.c FROM data AS left, data AS right").await } +#[tokio::test] +async fn self_join_introduces_aliases() -> Result<()> { Review Comment: This is adding that test back with the SubqueryAlias, yes. If you think it's redundant with `roundtrip_self_join` I'm happy to remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org