alamb opened a new pull request, #13947: URL: https://github.com/apache/datafusion/pull/13947
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes https://github.com/apache/datafusion/issues/13946 ## Rationale for this change 1. After https://github.com/apache/datafusion/pull/12978 from @adriangb (❤️ ) the test_fuzz_utf8 test takes over a minute to run on my machine 2. It is also not especially clear what it is doing or what is taking the time ## What changes are included in this PR? 1. Break the test into multiple individual test cases that each test a particular predicate 2. The logic is still the same (no changes are intended) New output: longest test now takes 12 seconds Example: ``` andrewlamb@Mac:~/Software/datafusion$ cargo nextest run --test fuzz -- pruning Compiling datafusion v44.0.0 (/Users/andrewlamb/Software/datafusion/datafusion/core) Finished `test` profile [unoptimized + debuginfo] target(s) in 2.08s ------------ Nextest run ID d214dd1d-952c-4280-a2b6-14f2d0109b79 with nextest profile: default Starting 12 tests across 1 binary (46 tests skipped) PASS [ 1.778s] datafusion::fuzz fuzz_cases::pruning::test_utf8_eq PASS [ 2.066s] datafusion::fuzz fuzz_cases::pruning::test_utf8_gt_eq PASS [ 2.095s] datafusion::fuzz fuzz_cases::pruning::test_utf8_lt PASS [ 2.153s] datafusion::fuzz fuzz_cases::pruning::test_utf8_gt PASS [ 2.175s] datafusion::fuzz fuzz_cases::pruning::test_utf8_lt_eq PASS [ 2.967s] datafusion::fuzz fuzz_cases::pruning::test_utf8_not_eq PASS [ 6.688s] datafusion::fuzz fuzz_cases::pruning::test_utf8_like PASS [ 7.283s] datafusion::fuzz fuzz_cases::pruning::test_utf8_not_like PASS [ 9.060s] datafusion::fuzz fuzz_cases::pruning::test_utf8_like_suffix PASS [ 9.389s] datafusion::fuzz fuzz_cases::pruning::test_utf8_like_prefix PASS [ 9.912s] datafusion::fuzz fuzz_cases::pruning::test_utf8_not_like_suffix PASS [ 12.013s] datafusion::fuzz fuzz_cases::pruning::test_utf8_not_like_prefix ``` ## Are these changes tested? Yes, by CI <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
