jonahgao commented on code in PR #13917: URL: https://github.com/apache/datafusion/pull/13917#discussion_r1898912465
########## datafusion/sqllogictest/test_files/group_by.slt: ########## @@ -80,7 +80,7 @@ SELECT col1 * cor0.col1 * 56 AS col1 FROM tab2 AS cor0 GROUP BY cor0.col1 208376 94136 -query I rowsort label-4 +query I rowsort Review Comment: These tests come from sqlite, where `label` is the syntax of sqlite, used to verify that queries with the same label yield the same result. Within this SLT, we don't have the same labels, so this is meaningless. Additionally, sqllogictest-rs does not support this syntax. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
