alamb opened a new pull request, #1626: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1626
- Follow on to https://github.com/apache/datafusion-sqlparser-rs/pull/1618 - Part of https://github.com/apache/datafusion-sqlparser-rs/issues/1558 Rationale: @davisp made some great improvements to performance, but now the API for managing tokens is a bit unwieldy. Before we release a new version I am working to slim down the APIs (ideally so we can migrate more code to avoid cloning) Inspired by @iffyo's comments on https://github.com/apache/datafusion-sqlparser-rs/pull/1618 > Not sure I followed the intent of the comment, did it mean potentially replacing this api with something similar called advance or would that have a different behavior? I spent some time playing around with the API and I found these APIs are not necessary, so I propose removing them to simplify the parser interface Changes: 1. Remove `parse_keyword_token` and `parse_keyword_token_ref` in favor of get_current_token -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
