berkaysynnada commented on code in PR #13879:
URL: https://github.com/apache/datafusion/pull/13879#discussion_r1895488724
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -170,7 +170,7 @@ impl RepartitionExecState {
/// which is commonly set to the number of CPU cores and all call execute at
the same time.
///
/// Thus, use a **tokio** `OnceCell` for this initialization so as not to
waste CPU cycles
-/// in a futex lock but instead allow other threads to do something useful.
Review Comment:
futex word might be correct here
##########
datafusion-examples/examples/catalog.rs:
##########
@@ -144,8 +144,8 @@ impl DirSchema {
async fn create(state: &SessionState, opts: DirSchemaOpts<'_>) ->
Result<Arc<Self>> {
let DirSchemaOpts { ext, dir, format } = opts;
let mut tables = HashMap::new();
- let direntries = std::fs::read_dir(dir).unwrap();
- for res in direntries {
+ let directories = std::fs::read_dir(dir).unwrap();
Review Comment:
It is dir_entries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
