alamb commented on code in PR #13874:
URL: https://github.com/apache/datafusion/pull/13874#discussion_r1894978630


##########
datafusion/core/src/dataframe/parquet.rs:
##########
@@ -74,8 +74,16 @@ impl DataFrame {
 
         let file_type = format_as_file_type(format);
 
+        let plan = if options.sort_by.is_empty() {
+            self.plan
+        } else {
+            LogicalPlanBuilder::from(self.plan)
+                .sort(options.sort_by)?
+                .build()?
+        };
+

Review Comment:
   I think copy_to inserts the data from whatever the input plan is (if there 
is a redundant sort the optimizer will remove it). Is that what you are asking?
   
   It is an interesting question of how to communicate "this table is sorted" 
information for newly written files. Is this what you are talking about?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to