wiedld commented on code in PR #13866:
URL: https://github.com/apache/datafusion/pull/13866#discussion_r1894526006


##########
datafusion/common/src/file_options/parquet_writer.rs:
##########
@@ -140,6 +162,32 @@ impl TryFrom<&TableParquetOptions> for 
WriterPropertiesBuilder {
     }
 }
 
+/// Encodes the Arrow schema into the IPC format, and base64 encodes it
+///
+/// TODO: make arrow schema encoding available in a public API.
+/// Refer to currently private `add_encoded_arrow_schema_to_metadata` and 
`encode_arrow_schema` public.
+/// 
<https://github.com/apache/arrow-rs/blob/2908a80d9ca3e3fb0414e35b67856f1fb761304c/parquet/src/arrow/schema/mod.rs#L172-L221>
+fn encode_arrow_schema(schema: &Arc<Schema>) -> String {

Review Comment:
   If we are in agreement on need, I'll go make the arrow-rs PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to