alamb commented on PR #13651: URL: https://github.com/apache/datafusion/pull/13651#issuecomment-2557756719
> I propose that we add another full InvariantLevel::Executable between each optimization pass, that only runs in debug mode (since that will be a performance impact as @findepi mentioned). Perhaps we can do this as a follow on PR > I can also make some of these check listed above into debug only, if the current performance change is unacceptable. Yes, I think this is important for two reasons: 1. I think we can't introduce a 25% planning performance regression 2. Adidng a check to help development that will generate errors in plans that used to run to completion will likely be seen as a regression for users I am checking out the rest of this PR now as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
