andygrove commented on code in PR #1191:
URL: https://github.com/apache/datafusion-comet/pull/1191#discussion_r1894276152
##########
native/spark-expr/src/cast.rs:
##########
@@ -138,240 +138,6 @@ pub struct Cast {
pub cast_options: SparkCastOptions,
}
-/// Determine if Comet supports a cast, taking options such as EvalMode and
Timezone into account.
-pub fn cast_supported(
- from_type: &DataType,
Review Comment:
I moved this into schema_adapter as a private function since it is specific
to reading parquet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
