andygrove commented on code in PR #1185:
URL: https://github.com/apache/datafusion-comet/pull/1185#discussion_r1893238118
##########
native/core/src/execution/shuffle/row.rs:
##########
@@ -3358,7 +3359,9 @@ pub fn process_sorted_row_partition(
// we do not collect metrics in Native_writeSortedFileNative
let ipc_time = Time::default();
- written += write_ipc_compressed(&batch, &mut cursor, &ipc_time)?;
+ // compression codec is not configurable for
CometBypassMergeSortShuffleWriter
Review Comment:
This PR only makes compression configurable for native shuffle and not for
our JVM columnar shuffle. I updated the PR title to make this clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
