jayzhan211 commented on code in PR #13840:
URL: https://github.com/apache/datafusion/pull/13840#discussion_r1891862598
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -123,24 +127,29 @@ pub enum TypeSignature {
/// One or more arguments belonging to the [`TypeSignatureClass`], in
order.
///
/// For example, `Coercible(vec![logical_float64()])` accepts
- /// arguments like `vec![DataType::Int32]` or `vec![DataType::Float32]`
+ /// arguments like `vec![Int32]` or `vec![Float32]`
/// since i32 and f32 can be cast to f64
///
/// For functions that take no arguments (e.g. `random()`) see
[`TypeSignature::Nullary`].
Coercible(Vec<TypeSignatureClass>),
- /// One or more arguments that can be "compared"
+ /// One or more arguments cast to single, comparable type.
+ ///
+ /// Each argument will be coerced to a single type using the
+ /// coercion rules described in [`comparison_coercion_numeric`].
Review Comment:
yes, we have numeric currently, update doc when code is updated to be
consistent
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -123,24 +127,29 @@ pub enum TypeSignature {
/// One or more arguments belonging to the [`TypeSignatureClass`], in
order.
///
/// For example, `Coercible(vec![logical_float64()])` accepts
- /// arguments like `vec![DataType::Int32]` or `vec![DataType::Float32]`
+ /// arguments like `vec![Int32]` or `vec![Float32]`
/// since i32 and f32 can be cast to f64
///
/// For functions that take no arguments (e.g. `random()`) see
[`TypeSignature::Nullary`].
Coercible(Vec<TypeSignatureClass>),
- /// One or more arguments that can be "compared"
+ /// One or more arguments cast to single, comparable type.
+ ///
+ /// Each argument will be coerced to a single type using the
+ /// coercion rules described in [`comparison_coercion_numeric`].
Review Comment:
yes, but we have numeric currently, update doc when code is updated to be
consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
