jayzhan211 commented on code in PR #13826:
URL: https://github.com/apache/datafusion/pull/13826#discussion_r1890161313


##########
datafusion/physical-plan/src/sorts/sort_preserving_merge.rs:
##########
@@ -105,6 +119,14 @@ impl SortPreservingMergeExec {
     }
 
     /// Sets the selection strategy of tied winners of the loser tree algorithm
+    ///
+    /// When true (the default) equal output rows are placed in the merged
+    /// stream when ready, which is faster but not stable (can vary from
+    /// run to run).

Review Comment:
   Poll may be pending so value is not yet ready?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to