vbarua commented on code in PR #13772:
URL: https://github.com/apache/datafusion/pull/13772#discussion_r1889326363
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -994,8 +994,34 @@ pub async fn from_substrait_rel(
)
.await
}
- _ => {
- not_impl_err!("Unsupported ReadType: {:?}",
&read.as_ref().read_type)
+ Some(ReadType::ExtensionTable(ext)) => {
Review Comment:
> (and SubstraitProducer?)
I haven't gotten around to the producer yet, but if the SubstraitConsumer
pattern makes sense to folks it should be easy enough to hammer it out.
> I think the code here is really easy to migrate to the new
SubstraitConsumer
Would you be open to having https://github.com/apache/datafusion/pull/13803
merged first, and then porting your code over?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
