wiedld commented on code in PR #13651:
URL: https://github.com/apache/datafusion/pull/13651#discussion_r1886207811
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1125,6 +1126,14 @@ impl LogicalPlan {
}
}
+ /// These are invariants to hold true for each logical plan.
+ pub fn assert_invariants(&self) -> Result<()> {
+ // Refer to
<https://datafusion.apache.org/contributor-guide/specification/invariants.html#relation-name-tuples-in-logical-fields-and-logical-columns-are-unique>
+ assert_unique_field_names(self)?;
+
Review Comment:
I removed the `assert_unions_are_valid` because I was not sure if it should
be a LP invariant (it's [not listed
here](https://datafusion.apache.org/contributor-guide/specification/invariants.html#id4)),
and it caused ~17 test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
