alamb commented on PR #13582: URL: https://github.com/apache/datafusion/pull/13582#issuecomment-2544125657
> Are there SQL-like paths for registration (I thought CREATE TABLE had a different trait for some reason)? There is very basic support in `SessionContext::sql` for handling `CREATE TABLE` via [`SessionContext::execute_logical_plan`](https://docs.rs/datafusion/latest/datafusion/execution/context/struct.SessionContext.html#method.execute_logical_plan) I don't think `CREATE TABLE` has a specific trait that I can think of 🤔 > Do you see any reason users might want to do catalog registration via DF instead of directly with the catalog? If so, maybe we move forward with this PR. I think what people can do if they want to customize the registration is to run `SessionState::create_logical_plan` and then write code that handles `LogicalPlan::DDL` however they see fit (sync / async, whatever) In general, my major concern with this PR is really the amount of downstream churn it will create given the viral nature of `async` (and that we have been dealing with some touch upgrades recently, see https://github.com/apache/datafusion/issues/13648) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
