findepi commented on code in PR #13747:
URL: https://github.com/apache/datafusion/pull/13747#discussion_r1883714260
##########
datafusion/sqllogictest/src/engines/conversion.rs:
##########
@@ -149,19 +128,41 @@ mod tests {
#[test]
fn test_big_decimal_to_str() {
Review Comment:
maybe not, but this also tests for normalization if any, and this may be
type dependent
this test and the tested helper were supposed to go away, see last commit in
https://github.com/apache/datafusion/pull/13743. Hopefully this lands one day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
