alamb commented on code in PR #13690:
URL: https://github.com/apache/datafusion/pull/13690#discussion_r1874985302
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -843,10 +843,22 @@ impl TableProvider for ListingTable {
});
// TODO (https://github.com/apache/datafusion/issues/11600) remove
downcast_ref from here?
let session_state =
state.as_any().downcast_ref::<SessionState>().unwrap();
- let (mut partitioned_file_lists, statistics) = self
- .list_files_for_scan(session_state, &partition_filters, limit)
+ // TODO avoid these clones when possible.
+ let session_state_captured = session_state.clone();
Review Comment:
There are quite a few more call sites like this that would need to be
annotated for the correct runtime. However I didn't bother to do it unless we
could figure out how to make the rest of the API reasonable (aka `run_cpu` ,etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
