alamb commented on code in PR #13637:
URL: https://github.com/apache/datafusion/pull/13637#discussion_r1868550990
##########
datafusion/physical-expr/src/scalar_function.rs:
##########
@@ -134,20 +134,20 @@ impl PhysicalExpr for ScalarFunctionExpr {
}
fn evaluate(&self, batch: &RecordBatch) -> Result<ColumnarValue> {
Review Comment:
I think we could potentially increase the number of places arrays could be
reused by changing this particular API to take `batch` (owned) and threading
that more fully through the physical exprs.
Until there is some compelling usecase to do so, however, I don't think we
should go mess with the APIs again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
