andygrove commented on code in PR #1152:
URL: https://github.com/apache/datafusion-comet/pull/1152#discussion_r1874535391
##########
native/spark-expr/src/sum_decimal.rs:
##########
@@ -286,18 +284,16 @@ struct SumDecimalGroupsAccumulator {
sum: Vec<i128>,
result_type: DataType,
precision: u8,
- scale: i8,
}
impl SumDecimalGroupsAccumulator {
- fn new(result_type: DataType, precision: u8, scale: i8) -> Self {
Review Comment:
`scale` was unused but the core crate suppresses dead code warnings so we
did not know until this was moved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
