goldmedal commented on code in PR #13660:
URL: https://github.com/apache/datafusion/pull/13660#discussion_r1871208568
##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -525,6 +525,60 @@ fn roundtrip_statement_with_dialect() -> Result<()> {
parser_dialect: Box::new(GenericDialect {}),
unparser_dialect: Box::new(SqliteDialect {}),
},
+ TestStatementWithDialect {
+ sql: "SELECT * FROM UNNEST([1,2,3])",
+ expected: r#"SELECT * FROM UNNEST([1, 2, 3])"#,
+ parser_dialect: Box::new(GenericDialect {}),
+ unparser_dialect:
Box::new(CustomDialectBuilder::default().with_unnest_as_table_factor(true).build()),
+ },
+ TestStatementWithDialect {
+ sql: "SELECT * FROM UNNEST([1,2,3]) AS t1 (c1)",
+ expected: r#"SELECT * FROM UNNEST([1, 2, 3]) AS t1 (c1)"#,
+ parser_dialect: Box::new(GenericDialect {}),
+ unparser_dialect:
Box::new(CustomDialectBuilder::default().with_unnest_as_table_factor(true).build()),
+ },
+ TestStatementWithDialect {
+ sql: "SELECT * FROM UNNEST([1,2,3]) AS t1 (c1)",
+ expected: r#"SELECT * FROM UNNEST([1, 2, 3]) AS t1 (c1)"#,
+ parser_dialect: Box::new(GenericDialect {}),
+ unparser_dialect:
Box::new(CustomDialectBuilder::default().with_unnest_as_table_factor(true).build()),
+ },
+ TestStatementWithDialect {
+ sql: "SELECT * FROM UNNEST([1,2,3]), j1",
+ expected: r#"SELECT * FROM UNNEST([1, 2, 3]) CROSS JOIN j1"#,
+ parser_dialect: Box::new(GenericDialect {}),
+ unparser_dialect:
Box::new(CustomDialectBuilder::default().with_unnest_as_table_factor(true).build()),
+ },
+ TestStatementWithDialect {
+ sql: "SELECT * FROM UNNEST([1,2,3]) u(c1) JOIN j1 ON u.c1 =
j1.j1_id",
+ expected: r#"SELECT * FROM UNNEST([1, 2, 3]) AS u (c1) JOIN j1 ON
(u.c1 = j1.j1_id)"#,
+ parser_dialect: Box::new(GenericDialect {}),
+ unparser_dialect:
Box::new(CustomDialectBuilder::default().with_unnest_as_table_factor(true).build()),
+ },
+ TestStatementWithDialect {
+ sql: "SELECT * FROM UNNEST([1,2,3]) u(c1) UNION ALL SELECT * FROM
UNNEST([4,5,6]) u(c1)",
+ expected: r#"SELECT * FROM UNNEST([1, 2, 3]) AS u (c1) UNION ALL
SELECT * FROM UNNEST([4, 5, 6]) AS u (c1)"#,
+ parser_dialect: Box::new(GenericDialect {}),
+ unparser_dialect:
Box::new(CustomDialectBuilder::default().with_unnest_as_table_factor(true).build()),
+ },
+ TestStatementWithDialect {
+ sql: "SELECT UNNEST([1,2,3])",
+ expected: r#"SELECT * FROM UNNEST([1, 2, 3])"#,
Review Comment:
Because the logical plan of `SELECT UNNEST([1,2,3])` and `SELECT * FROM
UNNEST([1, 2, 3])` is the same, if the `with_unnest_as_table_factor` is
enabled, we can't avoid to unparse it to the table factor SQL. However, I guess
it's fine because they are the same in most scenarios. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
