alamb commented on PR #13637: URL: https://github.com/apache/datafusion/pull/13637#issuecomment-2519018011
> lgtm thanks @alamb wondering should we create a small bench to see the performance gain? > > I can take care on that if needed Thank you very much for the review @comphead If wanted to see a perfomance gain, I think we need to 1. have a query where expression evaluation with a function is is a significant portion of the query time 2. rewrite the funtion in question to use this array reuse strategy My motivation for changing this API now (without a realistic driving case) was to avoid releasing a version of ScalarFunctionArgs that passed a reference (rather than a `Vec`) Then @findepi recommeneded ensuring that an owned API could actually be used to avoid allocating during execution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
