andygrove commented on code in PR #1133:
URL: https://github.com/apache/datafusion-comet/pull/1133#discussion_r1867941872
##########
native/core/src/execution/operators/scan.rs:
##########
@@ -200,6 +217,21 @@ impl ScanExec {
let mut env = JVMClasses::get_env()?;
+ let mut timer = jvm_fetch_time.timer();
+
+ let num_rows: i32 = unsafe {
+ jni_call!(&mut env,
+ comet_batch_iterator(iter).has_next() -> i32)?
+ };
Review Comment:
Ideally, I would have had `has_next` return a `bool` rather than `i32` but I
could not figure out how to make that happen with our jni macros. I am open to
suggestions on how to improve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
