parthchandra commented on code in PR #1101:
URL: https://github.com/apache/datafusion-comet/pull/1101#discussion_r1866392799
##########
native/core/src/execution/jni_api.rs:
##########
@@ -115,36 +117,10 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_createPlan(
// Deserialize query plan
let spark_plan = serde::deserialize_op(bytes.as_slice())?;
- // Sets up context
Review Comment:
Perhaps we can put this in an `initConf` that is called only once per
session? That allows us the flexibility to pass more session configuration
parameters if needed down the road? Or maybe that can be done later if the need
arises.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
