andygrove commented on code in PR #1128:
URL: https://github.com/apache/datafusion-comet/pull/1128#discussion_r1866410491
##########
native/core/src/execution/operators/scan.rs:
##########
@@ -88,6 +90,7 @@ impl ScanExec {
) -> Result<Self, CometError> {
let metrics_set = ExecutionPlanMetricsSet::default();
let baseline_metrics = BaselineMetrics::new(&metrics_set, 0);
+ let arrow_ffi_time =
MetricBuilder::new(&metrics_set).subset_time("arrow_ffi_time", 0);
Review Comment:
It is zero copy for the data buffers, but the schema does get serialized
with each batch. However, it does not look to be an issue after all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
