comphead commented on code in PR #13596:
URL: https://github.com/apache/datafusion/pull/13596#discussion_r1862634805
##########
datafusion/functions-nested/src/concat.rs:
##########
@@ -438,7 +438,7 @@ fn concat_internal<O: OffsetSizeTrait>(args: &[ArrayRef])
-> Result<ArrayRef> {
Ok(Arc::new(list_arr))
}
-/// Kernal functions
+// Kernal functions
Review Comment:
```suggestion
// Kernel functions
```
##########
datafusion/expr-common/src/type_coercion/aggregates.rs:
##########
@@ -294,19 +294,19 @@ pub fn coerce_avg_type(func_name: &str, arg_types:
&[DataType]) -> Result<Vec<Da
// Supported types smallint, int, bigint, real, double precision, decimal,
or interval
// Refer to https://www.postgresql.org/docs/8.2/functions-aggregate.html
doc
fn coerced_type(func_name: &str, data_type: &DataType) -> Result<DataType>
{
- return match &data_type {
+ match &data_type {
DataType::Decimal128(p, s) => Ok(DataType::Decimal128(*p, *s)),
DataType::Decimal256(p, s) => Ok(DataType::Decimal256(*p, *s)),
d if d.is_numeric() => Ok(DataType::Float64),
- DataType::Dictionary(_, v) => return coerced_type(func_name,
v.as_ref()),
Review Comment:
oh that becomes a clippy complaint finally
##########
datafusion/expr/src/logical_plan/display.rs:
##########
@@ -181,7 +181,7 @@ impl<'a, 'b> GraphvizVisitor<'a, 'b> {
}
}
-impl<'n, 'a, 'b> TreeNodeVisitor<'n> for GraphvizVisitor<'a, 'b> {
Review Comment:
the underscore does it mean unused lifetime?
##########
datafusion/physical-plan/src/sorts/sort_preserving_merge.rs:
##########
@@ -746,7 +746,7 @@ mod tests {
// Split the provided record batch into multiple batch_size record batches
fn split_batch(sorted: &RecordBatch, batch_size: usize) ->
Vec<RecordBatch> {
- let batches = (sorted.num_rows() + batch_size - 1) / batch_size;
Review Comment:
was it a clippy complaint?
##########
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##########
@@ -54,8 +54,6 @@ use datafusion_expr::{Aggregate, Distinct, DistinctOn, Expr,
LogicalPlan};
/// )
/// ORDER BY a DESC
/// ```
-
-/// Optimizer that replaces logical [[Distinct]] with a logical [[Aggregate]]
Review Comment:
do we need the comment to be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
