tustvold commented on code in PR #13582:
URL: https://github.com/apache/datafusion/pull/13582#discussion_r1860919281
##########
datafusion/catalog/src/catalog.rs:
##########
@@ -153,22 +155,23 @@ pub trait CatalogProvider: Debug + Sync + Send {
///
/// Please see the documentation on `CatalogProvider` for details of
/// implementing a custom catalog.
+#[async_trait]
pub trait CatalogProviderList: Debug + Sync + Send {
/// Returns the catalog list as [`Any`]
/// so that it can be downcast to a specific implementation.
fn as_any(&self) -> &dyn Any;
/// Adds a new catalog to this catalog list
/// If a catalog of the same name existed before, it is replaced in the
list and returned.
- fn register_catalog(
+ async fn register_catalog(
&self,
name: String,
catalog: Arc<dyn CatalogProvider>,
) -> Option<Arc<dyn CatalogProvider>>;
/// Retrieves the list of available catalog names
- fn catalog_names(&self) -> Vec<String>;
+ async fn catalog_names(&self) -> Vec<String>;
Review Comment:
This could also be a stream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
