iffyio commented on code in PR #1547:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1547#discussion_r1860757158
##########
src/parser/mod.rs:
##########
@@ -11411,6 +11411,9 @@ impl<'a> Parser<'a> {
Token::Colon if
self.dialect.supports_named_fn_args_with_colon_operator() => {
Ok(FunctionArgOperator::Colon)
}
+ Token::Word(w) if w.value.eq_ignore_ascii_case("value") => {
Review Comment:
hmm not sure I follow by it being out of scope. Took a quick look and VALUE
is also already a keyword so that the PR doesn't need to touch that file
either. thinking the changes required in the pr could be something like this to
use the convention vs comparing the raw string?
```rust
if self.parse_keyword(Keyword::VALUE) {
return Ok(FunctionArgOperator::Value)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
