alamb commented on code in PR #1560:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1560#discussion_r1858815574
##########
sqlparser_bench/benches/sqlparser_bench.rs:
##########
@@ -23,24 +23,24 @@ fn basic_queries(c: &mut Criterion) {
let mut group = c.benchmark_group("sqlparser-rs parsing benchmark");
let dialect = GenericDialect {};
- let string = "SELECT * FROM table WHERE 1 = 1";
+ let string = "SELECT * FROM my_table WHERE 1 = 1";
Review Comment:
"table" is a keyword so you can't use it as a table name without putting it
in quotes
##########
sqlparser_bench/benches/sqlparser_bench.rs:
##########
@@ -23,24 +23,24 @@ fn basic_queries(c: &mut Criterion) {
let mut group = c.benchmark_group("sqlparser-rs parsing benchmark");
let dialect = GenericDialect {};
- let string = "SELECT * FROM table WHERE 1 = 1";
+ let string = "SELECT * FROM my_table WHERE 1 = 1";
group.bench_function("sqlparser::select", |b| {
- b.iter(|| Parser::parse_sql(&dialect, string));
+ b.iter(|| Parser::parse_sql(&dialect, string).unwrap());
Review Comment:
The `unwrap` now actually checks the error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
