akurmustafa commented on code in PR #13554:
URL: https://github.com/apache/datafusion/pull/13554#discussion_r1857688000
##########
datafusion/functions-aggregate/src/median.rs:
##########
@@ -310,6 +310,18 @@ impl<T: ArrowNumericType> Accumulator for
DistinctMedianAccumulator<T> {
}
}
+/// Get maximum entry in the slice,
+fn slice_max<T>(array: &[T::Native]) -> Option<T::Native>
+where
+ T: ArrowPrimitiveType,
+ T::Native: PartialOrd, // Ensure the type supports PartialOrd for
comparison
+{
Review Comment:
That makes sense to me, updated the implementation such that function
doesn't return option in
[0303c9](https://github.com/apache/datafusion/pull/13554/commits/0303c965466c3b443f85e799fc3d8392877dbd20)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
