viirya commented on code in PR #1094:
URL: https://github.com/apache/datafusion-comet/pull/1094#discussion_r1847323816
##########
native/core/src/execution/jni_api.rs:
##########
@@ -287,7 +287,7 @@ fn prepare_output(
let results = output_batch.columns();
let num_rows = output_batch.num_rows();
- if results.len() != num_cols {
+ if results.len() < num_cols {
Review Comment:
A failed query has no output on the scan. I.e., the query asks for empty
column. But the native scan still outputs all columns. It should be more
reasonable to output no column, actually. Let me see if it could be fixed at
the native scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
