alamb commented on code in PR #13421:
URL: https://github.com/apache/datafusion/pull/13421#discussion_r1842889745
##########
datafusion/proto/src/physical_plan/to_proto.rs:
##########
@@ -120,6 +120,25 @@ pub fn serialize_physical_window_expr(
window_frame,
codec,
)?
+ } else if let Some(built_in_window_expr) =
expr.downcast_ref::<BuiltInWindowExpr>() {
Review Comment:
The naming of these structures is wild (the physical exprs aren't actually
BuiltInWindowExprs) but that is an issue to fix for another day
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
