findepi commented on issue #12819:
URL: https://github.com/apache/datafusion/issues/12819#issuecomment-2468826019
> This mean that the `ExprSimplifier` would change the return type of the
pack UDF.
>
> Say for instance the return (before simplification) is `("a", int64
nullable), ...` after would be `("a", int64 non nullable), ...`.
I don't see yet that it would
- UDF's return type is calculated, if it is a struct, it has determined
nullability of fields
- in https://github.com/apache/datafusion/pull/13290 that return type is
passed back to invoke, so that invoke can produce the result correctly
- alternatively to the above, same info can be passed so simplify(), so that
new UDF instance is created capturing the return type information. The return
type doesn't change
- invoke on such instance would work exactly as desired, having access to
the information from the return type
What is this analysis missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
