alamb commented on code in PR #13294:
URL: https://github.com/apache/datafusion/pull/13294#discussion_r1835008187


##########
datafusion/sql/src/planner.rs:
##########
@@ -401,6 +401,14 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
     }
 
     pub(crate) fn convert_data_type(&self, sql_type: &SQLDataType) -> 
Result<DataType> {
+        // First check if any of the registered expr_planners can handle this 
type
+        for expr_planner in self.context_provider.get_expr_planners() {

Review Comment:
   Yes I think that makes sense to me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to