timsaucer commented on PR #912: URL: https://github.com/apache/datafusion-python/pull/912#issuecomment-2464525604
Thanks for the update to fix the CI. We talked on discord and it brought up another issue - this is a breaking change for anyone who is currently doing a join without specifying the `on=` keyword. So we either need to make a change such that the old method of `df1.join(df2, (["col_a"], ["col_b"]))` will still work *OR* we have to make it clear that we've made a breaking API change and all users will need to update every instance of `join` in their code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
