LeslieKid commented on code in PR #13280:
URL: https://github.com/apache/datafusion/pull/13280#discussion_r1832163669
##########
datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs:
##########
@@ -171,6 +172,25 @@ fn baseline_config() -> DatasetGeneratorConfig {
ColumnDescr::new("time32_ms", DataType::Time32(TimeUnit::Millisecond)),
ColumnDescr::new("time64_us", DataType::Time64(TimeUnit::Microsecond)),
ColumnDescr::new("time64_ns", DataType::Time64(TimeUnit::Nanosecond)),
+ // TODO: randomize timezones for timestamp types
+ ColumnDescr::new("timestamp_s", DataType::Timestamp(TimeUnit::Second,
None)),
+ ColumnDescr::new(
+ "timestamp_ms",
+ DataType::Timestamp(TimeUnit::Millisecond, None),
+ ),
+ ColumnDescr::new(
+ "timestamp_us",
+ DataType::Timestamp(TimeUnit::Microsecond, None),
+ ),
+ ColumnDescr::new(
+ "timestamp_ns",
+ DataType::Timestamp(TimeUnit::Nanosecond, None),
+ ),
+ ColumnDescr::new("binary", DataType::Binary),
+ ColumnDescr::new("large_binary", DataType::LargeBinary),
+ ColumnDescr::new("binaryview", DataType::BinaryView),
Review Comment:
I think we can put `binary` near `string` types instead of placing it in the
middle of some fixed-size primitive types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
