findepi commented on code in PR #13260:
URL: https://github.com/apache/datafusion/pull/13260#discussion_r1831797615
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -3633,32 +3697,123 @@ mod tests {
#[test]
fn test_like_and_ilke() {
- // LIKE '%'
- let expr = like(col("c1"), "%");
+ let null = lit(ScalarValue::Utf8(None));
+
+ // expr [NOT] [I]LIKE NULL
+ let expr = like(col("c1"), null.clone());
+ assert_eq!(simplify(expr), lit_bool_null());
+
+ let expr = not_like(col("c1"), null.clone());
+ assert_eq!(simplify(expr), lit_bool_null());
+
+ let expr = ilike(col("c1"), null.clone());
+ assert_eq!(simplify(expr), lit_bool_null());
+
+ let expr = not_ilike(col("c1"), null.clone());
+ assert_eq!(simplify(expr), lit_bool_null());
+
+ // expr [NOT] [I]LIKE '%'
+ let expr = like(col("c1"), lit("%"));
+ assert_eq!(simplify(expr), if_not_null(col("c1"), true));
+
+ let expr = not_like(col("c1"), lit("%"));
+ assert_eq!(simplify(expr), if_not_null(col("c1"), false));
+
+ let expr = ilike(col("c1"), lit("%"));
+ assert_eq!(simplify(expr), if_not_null(col("c1"), true));
+
+ let expr = not_ilike(col("c1"), lit("%"));
+ assert_eq!(simplify(expr), if_not_null(col("c1"), false));
+
+ // expr [NOT] [I]LIKE '%%'
Review Comment:
> In Postgres, `%%` doesn't mean matching the actual literal '%'. The escape
character is `\`.
thanks @goldmedal for checking this.
in our case, we don't have default escape character at all, i believe.
at least we don't define it on Like object.
i need to check whether we have an _implicit_ default escape character
applied somewhere later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
