alamb commented on code in PR #13222:
URL: https://github.com/apache/datafusion/pull/13222#discussion_r1829795153
##########
datafusion/core/src/physical_optimizer/enforce_sorting.rs:
##########
@@ -221,7 +221,7 @@ fn replace_with_partial_sort(
// here we're trying to find the common prefix for sorted columns that
is required for the
// sort and already satisfied by the given ordering
let child_eq_properties = child.equivalence_properties();
- let sort_req =
PhysicalSortRequirement::from_sort_exprs(sort_plan.expr());
+ let sort_req = LexRequirement::from(sort_plan.expr().clone());
Review Comment:
Again, there is no more cloning going on than previously, just now the clone
is explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
