comphead commented on code in PR #13203: URL: https://github.com/apache/datafusion/pull/13203#discussion_r1826268943
########## datafusion/physical-plan/src/joins/cross_join.rs: ########## @@ -51,7 +51,7 @@ type JoinLeftData = (RecordBatch, MemoryReservation); /// executes partitions in parallel and combines them into a set of /// partitions by combining all values from the left with all values on the right -#[derive(Debug)] +#[derive(Debug)] // note not Clone because of the OnceAsync Review Comment: ```suggestion /// Clone trait not derived because the structure used with `OnceAsync` which doesn't expect the structure to be cloned #[derive(Debug)] ``` ########## datafusion/physical-plan/src/joins/cross_join.rs: ########## @@ -51,7 +51,7 @@ type JoinLeftData = (RecordBatch, MemoryReservation); /// executes partitions in parallel and combines them into a set of /// partitions by combining all values from the left with all values on the right -#[derive(Debug)] +#[derive(Debug)] // note not Clone because of the OnceAsync Review Comment: perhaps something like that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
