alamb commented on code in PR #13197:
URL: https://github.com/apache/datafusion/pull/13197#discussion_r1826020761
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -39,6 +40,23 @@ pub fn main() -> Result<()> {
.block_on(run_tests())
}
+fn value_validator(actual: &[Vec<String>], expected: &[String]) -> bool {
+ let expected = expected
+ .iter()
+ // Trailing whitespace from lines in SLT will typically be removed,
but do not fail if it is not
+ // If particular test wants to cover trailing whitespace on a value,
Review Comment:
https://github.com/apache/datafusion/pull/13215
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -39,6 +40,23 @@ pub fn main() -> Result<()> {
.block_on(run_tests())
}
+fn value_validator(actual: &[Vec<String>], expected: &[String]) -> bool {
+ let expected = expected
+ .iter()
+ // Trailing whitespace from lines in SLT will typically be removed,
but do not fail if it is not
+ // If particular test wants to cover trailing whitespace on a value,
Review Comment:
- Follow on PR for documentation:
https://github.com/apache/datafusion/pull/13215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
