alamb opened a new pull request, #13206: URL: https://github.com/apache/datafusion/pull/13206
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Related to - https://github.com/apache/datafusion/issues/13060 - https://github.com/apache/datafusion/pull/13128 ## Rationale for this change While reviewing https://github.com/apache/datafusion/pull/13128 I noticed that the code got a bit more complicated because `Expr::volatile` returns `Result<bool>` and thus the calling code needs now to pass up `Results` However, `Expr::volatile` is actually infallible (never returns an error) so let's mark it as such to keep the code simpler This is also consistent with other `Expr` methods such as `Expr::any_column_refs` ## What changes are included in this PR? 1. Minor: `Expr::volatile` infallible <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? By existing CI ## Are there any user-facing changes? * The signature of `Expr::volatile` has changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
