alamb commented on PR #13133:
URL: https://github.com/apache/datafusion/pull/13133#issuecomment-2447870795

   Not sure what to make of the sort benchmark results: I will also try to run 
this to compare main/main to see how noisy it is:
   
   ```
   ++ critcmp main rrt-spm-upstream
   group                                      main                              
     rrt-spm-upstream
   -----                                      ----                              
     ----------------
   merge sorted f64                           1.00      4.8±0.02ms        ? 
?/sec    1.04      5.0±0.03ms        ? ?/sec
   merge sorted i64                           1.00      4.4±0.03ms        ? 
?/sec    1.08      4.8±0.02ms        ? ?/sec
   merge sorted mixed dictionary tuple        1.00     12.4±0.11ms        ? 
?/sec    1.06     13.2±0.07ms        ? ?/sec
   merge sorted mixed tuple                   1.03     11.7±0.05ms        ? 
?/sec    1.00     11.4±0.07ms        ? ?/sec
   merge sorted utf8 dictionary               1.00      4.2±0.04ms        ? 
?/sec    1.23      5.2±0.03ms        ? ?/sec
   merge sorted utf8 dictionary tuple         1.00      6.1±0.06ms        ? 
?/sec    1.23      7.5±0.05ms        ? ?/sec
   merge sorted utf8 high cardinality         1.00      6.8±0.04ms        ? 
?/sec    1.04      7.1±0.04ms        ? ?/sec
   merge sorted utf8 low cardinality          1.00      4.4±0.02ms        ? 
?/sec    1.15      5.0±0.04ms        ? ?/sec
   merge sorted utf8 tuple                    1.06     12.6±0.08ms        ? 
?/sec    1.00     11.8±0.06ms        ? ?/sec
   sort f64                                   1.01      3.4±0.01ms        ? 
?/sec    1.00      3.4±0.02ms        ? ?/sec
   sort i64                                   1.00      2.9±0.01ms        ? 
?/sec    1.10      3.2±0.01ms        ? ?/sec
   sort merge f64                             1.00      4.8±0.03ms        ? 
?/sec    1.04      5.0±0.03ms        ? ?/sec
   sort merge i64                             1.00      4.5±0.03ms        ? 
?/sec    1.09      4.9±0.02ms        ? ?/sec
   sort merge mixed dictionary tuple          1.00     12.2±0.09ms        ? 
?/sec    1.07     13.1±0.10ms        ? ?/sec
   sort merge mixed tuple                     1.03     11.8±0.09ms        ? 
?/sec    1.00     11.5±0.07ms        ? ?/sec
   sort merge utf8 dictionary                 1.00      4.0±0.02ms        ? 
?/sec    1.24      4.9±0.02ms        ? ?/sec
   sort merge utf8 dictionary tuple           1.00      6.0±0.06ms        ? 
?/sec    1.22      7.3±0.06ms        ? ?/sec
   sort merge utf8 high cardinality           1.00      7.0±0.03ms        ? 
?/sec    1.04      7.2±0.03ms        ? ?/sec
   sort merge utf8 low cardinality            1.00      4.5±0.02ms        ? 
?/sec    1.15      5.1±0.04ms        ? ?/sec
   sort merge utf8 tuple                      1.07     13.2±0.13ms        ? 
?/sec    1.00     12.3±0.10ms        ? ?/sec
   sort mixed dictionary tuple                1.00     18.4±0.21ms        ? 
?/sec    1.03     19.0±0.16ms        ? ?/sec
   sort mixed tuple                           1.03     15.2±0.14ms        ? 
?/sec    1.00     14.8±0.13ms        ? ?/sec
   sort partitioned f64                       1.11  220.0±458.22µs        ? 
?/sec    1.00  199.0±309.11µs        ? ?/sec
   sort partitioned i64                       1.00  201.0±421.49µs        ? 
?/sec    1.01  202.9±429.37µs        ? ?/sec
   sort partitioned mixed dictionary tuple    1.00  679.8±346.63µs        ? 
?/sec    1.04  704.1±262.66µs        ? ?/sec
   sort partitioned mixed tuple               1.00  547.8±146.14µs        ? 
?/sec    1.02  557.6±149.19µs        ? ?/sec
   sort partitioned utf8 dictionary           1.00  194.8±250.40µs        ? 
?/sec    1.09  211.6±418.05µs        ? ?/sec
   sort partitioned utf8 dictionary tuple     1.00  601.5±248.90µs        ? 
?/sec    1.03  622.0±241.48µs        ? ?/sec
   sort partitioned utf8 high cardinality     1.03  402.4±279.21µs        ? 
?/sec    1.00  390.0±180.70µs        ? ?/sec
   sort partitioned utf8 low cardinality      1.03  364.2±307.28µs        ? 
?/sec    1.00  353.7±264.51µs        ? ?/sec
   sort partitioned utf8 tuple                1.09  962.8±314.15µs        ? 
?/sec    1.00  886.0±186.74µs        ? ?/sec
   sort utf8 dictionary                       1.00  1094.0±17.08µs        ? 
?/sec    1.00  1094.3±16.54µs        ? ?/sec
   sort utf8 dictionary tuple                 1.00     11.4±0.09ms        ? 
?/sec    1.13     12.9±0.10ms        ? ?/sec
   sort utf8 high cardinality                 1.00     10.2±0.07ms        ? 
?/sec    1.02     10.5±0.07ms        ? ?/sec
   sort utf8 low cardinality                  1.00      7.3±0.03ms        ? 
?/sec    1.10      8.0±0.03ms        ? ?/sec
   sort utf8 tuple                            1.05     16.1±0.15ms        ? 
?/sec    1.00     15.4±0.11ms        ? ?/sec
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to