Rachelint commented on code in PR #12996:
URL: https://github.com/apache/datafusion/pull/12996#discussion_r1820062958
##########
datafusion/physical-plan/src/aggregates/group_values/group_column.rs:
##########
@@ -58,6 +63,17 @@ pub trait GroupColumn: Send + Sync {
fn equal_to(&self, lhs_row: usize, array: &ArrayRef, rhs_row: usize) ->
bool;
/// Appends the row at `row` in `array` to this builder
fn append_val(&mut self, array: &ArrayRef, row: usize);
+
+ fn vectorized_equal_to(
Review Comment:
It can get performance improvement due to eliminating the unnecessary
downcasting for each row.
And maybe can reduce the random memory accesses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
