jayzhan211 commented on code in PR #13133:
URL: https://github.com/apache/datafusion/pull/13133#discussion_r1819880186
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -97,6 +97,26 @@ pub(crate) struct SortPreservingMergeStream<C: CursorValues>
{
/// Cursors for each input partition. `None` means the input is exhausted
cursors: Vec<Option<Cursor<C>>>,
+ /// Configuration parameter to enable round-robin selection of tied
winners of loser tree.
+ enable_round_robin_tie_breaker: bool,
Review Comment:
We can see the difference in benchmark and test.
Here is the only place that remove this flag helps, so I guess remove the
flag doesn't help too much
```rust
if self.enable_round_robin_tie_breaker && cmp_node == 1 {
```
I'm ok to remove it too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
