andygrove commented on PR #1041:
URL:
https://github.com/apache/datafusion-comet/pull/1041#issuecomment-2441737970
> Interesting, I just reran the bench and I get the same improvements as
before. Should I compare the library implementation with the DataFusion custom
one to see if there is a difference?
It is possible that the results could vary depending on hardware. Out of
interest what platform are you testing on? I am testing on an AMD Ryzen 9 CPU
with Linux.
5% is a small price to pay to remove the custom implementation and go back
to using the dependency, IMO.
> Shall I add the following command to the docs: `cd native && cargo clippy
--color=never --all-targets --workspace -- -D warnings` in the [( Submitting a
PR
section)](https://datafusion.apache.org/comet/contributor-guide/development.html#submitting-a-pull-request)?
I think it would have saved me several CI runs.
That would be great as a separate PR, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
