findepi commented on code in PR #13143:
URL: https://github.com/apache/datafusion/pull/13143#discussion_r1819172891
##########
datafusion/functions/src/string/btrim.rs:
##########
@@ -124,6 +124,8 @@ fn get_btrim_doc() -> &'static Documentation {
```"#)
.with_standard_argument("str", Some("String"))
.with_argument("trim_str", "String expression to operate on. Can
be a constant, column, or function, and any combination of operators. _Default
is whitespace characters._")
+ .with_alternative_syntax("trim(BOTH trim_str FROM str)")
+ .with_alternative_syntax("trim(trim_str FROM str)")
Review Comment:
Does this deserve new SLT test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
