findepi commented on code in PR #12978:
URL: https://github.com/apache/datafusion/pull/12978#discussion_r1819181244
##########
datafusion/core/src/physical_optimizer/pruning.rs:
##########
@@ -3577,7 +3585,11 @@ mod tests {
// s1 ["A", NULL] ==> unknown (must keep)
// s1 ["", "A"] ==> some rows could pass (must keep)
// s1 ["", ""] ==> no rows can pass (not keep)
- let expected_ret = &[true, true, false, false, true, true, true,
false];
+ // s1 ["AB", "A\u{10ffff}"] ==> no rows can pass (not keep)
Review Comment:
> I take it you are saying each one of these should be their own test right?
not necessarily separate test funciton
just that having test case input and expected output next to each other
would help readability.
currently the test workarounds this by replicating input inside code
comments.
> just following the pattern other tests use
👍
let's not change this within this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
