Dandandan commented on code in PR #13134:
URL: https://github.com/apache/datafusion/pull/13134#discussion_r1818178088
##########
datafusion/physical-plan/src/joins/symmetric_hash_join.rs:
##########
@@ -708,6 +713,20 @@ where
{
// Store the result in a tuple
let result = match (build_side, join_type) {
+ (JoinSide::Left, JoinType::LeftMark) => {
+ let build_indices = (0..prune_length)
+ .map(L::Native::from_usize)
+ .collect::<PrimitiveArray<L>>();
+ let probe_indices = (0..prune_length)
+ .map(|idx| {
+ // For mark join we output a dummy index 0 to indicate the
row had a match
+ visited_rows
+ .contains(&(idx + deleted_offset))
+ .then_some(R::Native::from_usize(0).unwrap())
Review Comment:
How does this work, it will have probe indices with fewer number of indices?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
