timsaucer opened a new pull request, #13136:
URL: https://github.com/apache/datafusion/pull/13136

   ## Which issue does this PR close?
   
   This is to support https://github.com/apache/datafusion-python/issues/823 
and to address [this 
comment](https://github.com/apache/datafusion/pull/12920#pullrequestreview-2385761192)
 on https://github.com/apache/datafusion/pull/12920
   
   ## Rationale for this change
   
   This is a pure addition to the protobuf definition to allow for transferring 
`PlanProperties` in a serialized manner.
   
   ## What changes are included in this PR?
   
   - Adds protobuf message definitions for the plan properties and its 
contained fields
   - Adds methods to convert between these protobuf messages and their 
datafusion internal counterparts
   
   ## Are these changes tested?
   
   Tested locally against my code for 
https://github.com/apache/datafusion/pull/12920
   
   I did notice we don't really have unit tests for the other methods, so I 
didn't and any. I'm willing to do that, if desired.
   
   ## Are there any user-facing changes?
   
   No changes. Additional message definitions are available for use downstream, 
and particularly for the upcoming FFI work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to