Dandandan commented on code in PR #13133:
URL: https://github.com/apache/datafusion/pull/13133#discussion_r1818071424
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -127,12 +148,18 @@ impl<C: CursorValues> SortPreservingMergeStream<C> {
metrics,
aborted: false,
cursors: (0..stream_count).map(|_| None).collect(),
+ prev_cursors: (0..stream_count).map(|_| None).collect(),
+ round_robin_tie_breaker_mode: false,
+ num_of_polled_with_same_value: vec![0; stream_count],
Review Comment:
Hm yeah...
Thinking about it one more time, what about only keeping the previous
partition index that was chosen previously? We can always go to the next
partition:
* previous was 1, we have to chose between 0, 1 and 2: go to 2
* precious was 2, we have to chose between 0, 1 and 2, go to 0.
* etc..
This way we don't have to track / compare the counts? What would be the
pros/cons for this approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
